Skip to content

feat: add client_bin benchmark variable#165

Merged
meyer9 merged 1 commit intobase:mainfrom
Himess:feat/client-bin-variable
Feb 10, 2026
Merged

feat: add client_bin benchmark variable#165
meyer9 merged 1 commit intobase:mainfrom
Himess:feat/client-bin-variable

Conversation

@Himess
Copy link
Contributor

@Himess Himess commented Feb 9, 2026

Summary

  • Adds client_bin variable type to allow testing different client binary versions in a single benchmark run
  • Overrides the appropriate binary path (RethBin, GethBin, BuilderBin, BaseRethNodeBin) based on node_type

Closes #96

🤖 Generated with Claude Code

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 9, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@Himess Himess force-pushed the feat/client-bin-variable branch from 4d403df to d464412 Compare February 9, 2026 17:40
Copy link
Collaborator

@meyer9 meyer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@meyer9 meyer9 merged commit f6d3c3b into base:main Feb 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow client bin path to be specified via benchmark definition variable

3 participants